| Summary: | [LFC][IFC] imported/w3c/web-platform-tests/css/css-text/word-break/word-break-normal-ar-000.html fails with incorrect run position | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
zalan
2022-01-08 19:01:42 PST
Created attachment 448693 [details]
Patch
Comment on attachment 448693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448693&action=review > Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h:47 > + enum class UseTrailingWhitespaceMeasuringQuirk : uint8_t { Yes, No }; It is more like an optimization rather than quirk. It would be good to add a comment that explains what this does and why it is ok in LTR. Created attachment 448702 [details]
Patch
Created attachment 448735 [details]
Patch
Created attachment 449240 [details]
Patch
Committed r288055 (246075@main): <https://commits.webkit.org/246075@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449240 [details]. |