Bug 235008 – [Web Animations] getKeyframes() for a CSS Animation should not use computed style for keyframes

• Component: Animations
• Status: RESOLVED FIXED

[Antoine Quint]

[Web Animations] getKeyframes() for a CSS Animation should not use computed style for keyframes

[Antoine Quint]

Created attachment 448683 [details]
Patch

[Antoine Quint]

Committed r287820 (245872@trunk): <https://commits.webkit.org/245872@trunk>

[Radar WebKit Bug Importer]

<rdar://problem/87310877>

[Darin Adler]

Comment on attachment 448683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448683&action=review

> Source/WebCore/style/StyleResolver.h:142
> +    const Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&);

There signature here isn’t quite right. This should be a const member function and it should return a non-const Vector:

    Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&) const;

[Antoine Quint]

(In reply to Darin Adler from comment #4)
> Comment on attachment 448683 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448683&action=review
> 
> > Source/WebCore/style/StyleResolver.h:142
> > +    const Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&);
> 
> There signature here isn’t quite right. This should be a const member
> function and it should return a non-const Vector:
> 
>     Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&)
> const;

Filed bug 235021 to fix this.

[Antoine Quint]

We'll fix more of this in bug 235028.