Bug 235008

Summary: [Web Animations] getKeyframes() for a CSS Animation should not use computed style for keyframes
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, graouts, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=235021
https://bugs.webkit.org/show_bug.cgi?id=235028
Bug Depends on:    
Bug Blocks: 235138    
Attachments:
Description Flags
Patch koivisto: review+

Description Antoine Quint 2022-01-08 14:40:20 PST 
[Web Animations] getKeyframes() for a CSS Animation should not use computed style for keyframes
Comment 1 Antoine Quint 2022-01-08 14:47:48 PST 
Created attachment 448683 [details]
Patch
Comment 2 Antoine Quint 2022-01-09 07:35:24 PST 
Committed r287820 (245872@trunk): <https://commits.webkit.org/245872@trunk>
Comment 3 Radar WebKit Bug Importer 2022-01-09 07:36:21 PST 
<rdar://problem/87310877>
Comment 4 Darin Adler 2022-01-09 08:53:51 PST 
Comment on attachment 448683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448683&action=review

> Source/WebCore/style/StyleResolver.h:142
> +    const Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&);

There signature here isn’t quite right. This should be a const member function and it should return a non-const Vector:

    Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&) const;
Comment 5 Antoine Quint 2022-01-09 12:29:56 PST 
(In reply to Darin Adler from comment #4)
> Comment on attachment 448683 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448683&action=review
> 
> > Source/WebCore/style/StyleResolver.h:142
> > +    const Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&);
> 
> There signature here isn’t quite right. This should be a const member
> function and it should return a non-const Vector:
> 
>     Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&)
> const;

Filed bug 235021 to fix this.
Comment 6 Antoine Quint 2022-01-10 05:03:12 PST 
We'll fix more of this in bug 235028.