Bug 234995

Summary:

Make FullscreenManager::requestFullscreenForElement more robust

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, cdumez, changseok, cmarcelo, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kangil.han, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

233963

Attachments:

Description	Flags
Patch	none

Description Alex Christensen 2022-01-07 16:48:53 PST

Make FullscreenManager::requestFullscreenForElement more robust

Comment 1 Alex Christensen 2022-01-07 16:49:58 PST

Created attachment 448647 [details]
Patch

Comment 2 Darin Adler 2022-01-07 17:31:27 PST

Comment on attachment 448647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448647&action=review

> Source/WebCore/dom/FullscreenManager.cpp:116
> +    m_pendingFullscreenElement = RefPtr { element.ptr() };

I don’t think we have to write RefPtr here.

Comment 3 Alex Christensen 2022-01-07 17:36:29 PST

Comment on attachment 448647 [details]
Patch

we do!

Comment 4 EWS 2022-01-07 18:21:46 PST

Committed r287803 (245856@main): <https://commits.webkit.org/245856@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448647 [details].

Comment 5 Radar WebKit Bug Importer 2022-01-07 18:22:22 PST

<rdar://problem/87282270>