Bug 234995 - Make FullscreenManager::requestFullscreenForElement more robust
Summary: Make FullscreenManager::requestFullscreenForElement more robust
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Blocks: 233963
  Show dependency treegraph
Reported: 2022-01-07 16:48 PST by Alex Christensen
Modified: 2022-01-07 18:22 PST (History)
15 users (show)

See Also:

Patch (9.34 KB, patch)
2022-01-07 16:49 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-01-07 16:48:53 PST
Make FullscreenManager::requestFullscreenForElement more robust
Comment 1 Alex Christensen 2022-01-07 16:49:58 PST
Created attachment 448647 [details]
Comment 2 Darin Adler 2022-01-07 17:31:27 PST
Comment on attachment 448647 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=448647&action=review

> Source/WebCore/dom/FullscreenManager.cpp:116
> +    m_pendingFullscreenElement = RefPtr { element.ptr() };

I don’t think we have to write RefPtr here.
Comment 3 Alex Christensen 2022-01-07 17:36:29 PST
Comment on attachment 448647 [details]

we do!
Comment 4 EWS 2022-01-07 18:21:46 PST
Committed r287803 (245856@main): <https://commits.webkit.org/245856@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448647 [details].
Comment 5 Radar WebKit Bug Importer 2022-01-07 18:22:22 PST