Bug 234992

Summary: [LBSE] Begin layer-aware RenderSVGRect implementation
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, rbuis, sabouhallawa, schenney, sergio, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=240793
Bug Depends on: 234878, 234954    
Bug Blocks: 90738, 234632    
Attachments:
Description Flags
Patch, v1
none
Patch, v2 rbuis: review+, ews-feeder: commit-queue-

Description Nikolas Zimmermann 2022-01-07 15:21:23 PST 
Introduce the "layer-aware" RenderSVGRect implementation (inheriting from RenderSVGModelObject, and thus RenderLayerModelObject).
Besides the different inheritance structure with respect to LegacyRenderSVGRect (inheriting from LegacyRenderSVGModelObject, and thus RenderElement -- not RenderLayerModelObject), the implementation is identical to LegacyRenderSVGRect.
Comment 1 Nikolas Zimmermann 2022-01-07 15:41:41 PST 
Created attachment 448638 [details]
Patch, v1
Comment 2 Nikolas Zimmermann 2022-01-07 15:42:57 PST 
Comment on attachment 448638 [details]
Patch, v1

This patch depends on 234954, postponing r? / EWS until it's resolved.
Comment 3 Nikolas Zimmermann 2022-01-10 02:00:25 PST 
Created attachment 448728 [details]
Patch, v2
Comment 4 Rob Buis 2022-01-10 02:41:49 PST 
Comment on attachment 448728 [details]
Patch, v2

View in context: https://bugs.webkit.org/attachment.cgi?id=448728&action=review

> Source/WebCore/rendering/svg/RenderSVGRect.h:33
> +#include "SVGRectElement.h"

Could this be forward reference?

> Source/WebCore/svg/SVGRectElement.cpp:94
> +    if (0 && document().settings().layerBasedSVGEngineEnabled())

Maybe false is nicer.
Comment 5 Nikolas Zimmermann 2022-01-10 05:02:10 PST 
(In reply to Rob Buis from comment #4)
> Comment on attachment 448728 [details]
> Patch, v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448728&action=review
> 
> > Source/WebCore/rendering/svg/RenderSVGRect.h:33
> > +#include "SVGRectElement.h"
> 
> Could this be forward reference?
Yes, fixed, good catch.

> 
> > Source/WebCore/svg/SVGRectElement.cpp:94
> > +    if (0 && document().settings().layerBasedSVGEngineEnabled())
> 
> Maybe false is nicer.
Both are ugly, but I agree false is less ugly here. Fortunately this is only needed for a short period of time.

Thanks Rob again!
Comment 6 Nikolas Zimmermann 2022-01-10 05:10:59 PST 
Committed r287834 (245886@trunk): <https://commits.webkit.org/245886@trunk>
Comment 7 Radar WebKit Bug Importer 2022-01-10 05:11:21 PST 
<rdar://problem/87335756>