Bug 23498

Summary: compilation failure on linux/gtk
Product: WebKit Reporter: Craig Schlenter <craig.schlenter>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch to fix compilation problem darin: review+

Description Craig Schlenter 2009-01-23 01:27:23 PST 
RenderThemeGtk.cpp and PluginView.cpp don't compile properly as some methods have moved from RenderObject to RenderBox.

I'll attach a patch. Please review carefully as I'm clueless about this code and did the changes blindly to make things compile again.
Comment 1 Craig Schlenter 2009-01-23 01:29:20 PST 
Created attachment 26963 [details]
patch to fix compilation problem
Comment 2 Holger Freyther 2009-01-23 04:49:16 PST 
Thanks. The patch looks correct someone came up with another patch and will land it shortly.
Comment 3 Holger Freyther 2009-01-23 08:18:59 PST 
Oh, I took your RenderThemeGtk.cpp changes and slightly changed them on top of the other build fix. I think I properly credited this bug and your work.
Comment 4 Darin Adler 2009-01-23 12:37:00 PST 
Comment on attachment 26963 [details]
patch to fix compilation problem

r=me