| Summary: | Inserting a new @keyframes rule does not start animations that already used this name | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, graouts, koivisto, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar, WebExposed | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=234895 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 235138 | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2022-01-07 06:04:48 PST
Created attachment 448583 [details]
Patch
Comment on attachment 448583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448583&action=review > Source/WebCore/style/Styleable.cpp:216 > + for (size_t i = 0; i < animations.size(); ++i) { Might be good for the AnimationList to expose the underlying const vector so these could use range-for iteration. (In reply to Antti Koivisto from comment #2) > Comment on attachment 448583 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448583&action=review > > > Source/WebCore/style/Styleable.cpp:216 > > + for (size_t i = 0; i < animations.size(); ++i) { > > Might be good for the AnimationList to expose the underlying const vector so > these could use range-for iteration. See bug 234957. I'll use the iterator before landing this patch. Committed r287769 (245829@trunk): <https://commits.webkit.org/245829@trunk> |