| Summary: | Adopt linkedOnOrAfter() in more places | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | akeerthi, benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, mmaxfield, msaboff, saam, tzagallo, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2022-01-07 02:42:44 PST
Created attachment 448576 [details]
Patch
Comment on attachment 448576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448576&action=review This seems fine to me, given that we are already going down the `PLATFORM(IOS_FAMILY)` path on watchOS anyways (since `PLATFORM(WATCH)` is never defined on watchOS). It would be nice if some JSC folks could take a look as well. Separately, maybe we should consider actually avoiding this check on watchOS? > Source/JavaScriptCore/API/tests/testapi.mm:-2744 > -#elif PLATFORM(WATCH) (OOPS!) (In reply to Wenson Hsieh from comment #2) > Comment on attachment 448576 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448576&action=review > > This seems fine to me, given that we are already going down the > `PLATFORM(IOS_FAMILY)` path on watchOS anyways (since `PLATFORM(WATCH)` is > never defined on watchOS). Good point! Alas. > It would be nice if some JSC folks could take a look as well. > > Separately, maybe we should consider actually avoiding this check on watchOS? At the end of this patch series, the LOA checks will actually work /correctly/ on watchOS for the first time, so I don't think we need to special case anything. > > Source/JavaScriptCore/API/tests/testapi.mm:-2744 > > -#elif PLATFORM(WATCH) > > (OOPS!) Committed r287784 (245844@main): <https://commits.webkit.org/245844@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448576 [details]. |