Bug 234951

Summary:

Adopt linkedOnOrAfter() in more places

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

akeerthi, benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, mmaxfield, msaboff, saam, tzagallo, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Tim Horton

Reported 2022-01-07 02:42:44 PST

Adopt linkedOnOrAfter() in more places

Attachments
Patch (12.78 KB, patch) 2022-01-07 02:43 PST, Tim Horton	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2022-01-07 02:43:33 PST

Created attachment 448576 [details] Patch

Wenson Hsieh

Comment 2 2022-01-07 10:48:28 PST

Comment on attachment 448576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448576&action=review This seems fine to me, given that we are already going down the `PLATFORM(IOS_FAMILY)` path on watchOS anyways (since `PLATFORM(WATCH)` is never defined on watchOS). It would be nice if some JSC folks could take a look as well. Separately, maybe we should consider actually avoiding this check on watchOS? > Source/JavaScriptCore/API/tests/testapi.mm:-2744 > -#elif PLATFORM(WATCH) (OOPS!)

Tim Horton

Comment 3 2022-01-07 10:52:51 PST

(In reply to Wenson Hsieh from comment #2) > Comment on attachment 448576 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448576&action=review > > This seems fine to me, given that we are already going down the > `PLATFORM(IOS_FAMILY)` path on watchOS anyways (since `PLATFORM(WATCH)` is > never defined on watchOS). Good point! Alas. > It would be nice if some JSC folks could take a look as well. > > Separately, maybe we should consider actually avoiding this check on watchOS? At the end of this patch series, the LOA checks will actually work /correctly/ on watchOS for the first time, so I don't think we need to special case anything. > > Source/JavaScriptCore/API/tests/testapi.mm:-2744 > > -#elif PLATFORM(WATCH) > > (OOPS!)

EWS

Comment 4 2022-01-07 14:46:12 PST

Committed r287784 (245844@main): <https://commits.webkit.org/245844@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448576 [details].

Radar WebKit Bug Importer

Comment 5 2022-01-07 14:47:52 PST

<rdar://problem/87273517>

Note You need to log in before you can comment on or make changes to this bug.