Bug 234936

Summary: Use c++2a instead of gnu++2a for Cocoa builds
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, eric.carlson, ews-watchlist, hi, kbr, keith_miller, kondapallykalyan, mark.lam, msaboff, pangle, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Alex Christensen
Reported 2022-01-06 13:43:49 PST
Use c++2a instead of gnu++2a for Cocoa builds
Attachments
Patch (28.64 KB, patch)
2022-01-06 13:45 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (27.24 KB, patch)
2022-01-06 15:25 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-01-06 13:45:24 PST
Created attachment 448535 [details] Patch
EWS Watchlist
Comment 2 2022-01-06 13:46:13 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Alex Christensen
Comment 3 2022-01-06 15:25:54 PST
Created attachment 448540 [details] Patch
Sam Weinig
Comment 4 2022-01-07 14:56:48 PST
What's the reasoning behind this. My recollection is we have historically used the gnu++ standard flag (presumably at some point to use some gnu extensions, though clearly not vert much any more). What is the intended benefit here?
Radar WebKit Bug Importer
Comment 5 2022-01-13 13:44:29 PST
<rdar://problem/87568556>
Alex Christensen
Comment 6 2022-01-18 13:04:14 PST
Comment on attachment 448540 [details] Patch The intended benefit here is to have a consistent language standard among all WebKit ports.
EWS
Comment 7 2022-01-18 13:47:55 PST
Committed r288146 (246146@main): <https://commits.webkit.org/246146@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448540 [details].
Note You need to log in before you can comment on or make changes to this bug.