Bug 234897

Summary: Checkboxes on PurpleAir map controls are much smaller in Safari than other browsers
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: New BugsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237745    
Attachments:
Description Flags
For EWS
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Aditya Keerthi 2022-01-05 14:35:39 PST
SSIA
Comment 1 Aditya Keerthi 2022-01-05 14:35:54 PST
rdar://83367191
Comment 2 Aditya Keerthi 2022-01-05 14:51:51 PST
Created attachment 448428 [details]
For EWS
Comment 3 Aditya Keerthi 2022-01-05 14:59:28 PST
Created attachment 448430 [details]
Patch
Comment 4 Aditya Keerthi 2022-01-06 10:56:09 PST
Created attachment 448510 [details]
Patch
Comment 5 Aditya Keerthi 2022-01-06 10:57:20 PST
Created attachment 448511 [details]
Patch
Comment 6 Darin Adler 2022-01-06 11:24:58 PST
Comment on attachment 448511 [details]
Patch

What about PushButtonPart and InnerSpinButtonPart? They still both use a font-sized-based heuristic. Is that still valuable?
Comment 7 Aditya Keerthi 2022-01-06 12:47:44 PST
(In reply to Darin Adler from comment #6)
> Comment on attachment 448511 [details]
> Patch
> 
> What about PushButtonPart and InnerSpinButtonPart? They still both use a
> font-sized-based heuristic. Is that still valuable?

The heuristic is still valuable for PushButtonPart and InnerSpinButtonPart.

Similar to checkboxes and radio buttons, the rounded button (PushButtonPart) and spin buttons (InnerSpinButtonPart) are restricted to fixed control sizes in AppKit. However, unlike checkboxes and radio buttons, these controls have actual dependencies on font-size.

For the rounded buttons, we use larger AppKit control sizes as the font-size increases so that the text remains inside the button. Beyond a certain font-size, buttons begin to use AppKitā€™s square button appearance, which is not restricted to fixed sizes. 

For spin buttons (the stepper in <input type=number>) the heuristic is also needed, since they are inside a text box which resizes based on the font-size. The heuristic ensures the stepper fits the text box.
Comment 8 EWS 2022-01-07 09:34:06 PST
Committed r287753 (245816@main): <https://commits.webkit.org/245816@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448511 [details].