Bug 234897

Summary: Checkboxes on PurpleAir map controls are much smaller in Safari than other browsers
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: New BugsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237745    
Attachments:
Description Flags
For EWS
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Aditya Keerthi
Reported 2022-01-05 14:35:39 PST
SSIA
Attachments
For EWS (4.10 KB, patch)
2022-01-05 14:51 PST, Aditya Keerthi 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2022-01-05 14:59 PST, Aditya Keerthi 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (7.03 KB, patch)
2022-01-06 10:56 PST, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (6.99 KB, patch)
2022-01-06 10:57 PST, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2022-01-05 14:35:54 PST
rdar://83367191
Aditya Keerthi
Comment 2 2022-01-05 14:51:51 PST
Created attachment 448428 [details] For EWS
Aditya Keerthi
Comment 3 2022-01-05 14:59:28 PST
Created attachment 448430 [details] Patch
Aditya Keerthi
Comment 4 2022-01-06 10:56:09 PST
Created attachment 448510 [details] Patch
Aditya Keerthi
Comment 5 2022-01-06 10:57:20 PST
Created attachment 448511 [details] Patch
Darin Adler
Comment 6 2022-01-06 11:24:58 PST
Comment on attachment 448511 [details] Patch What about PushButtonPart and InnerSpinButtonPart? They still both use a font-sized-based heuristic. Is that still valuable?
Aditya Keerthi
Comment 7 2022-01-06 12:47:44 PST
(In reply to Darin Adler from comment #6) > Comment on attachment 448511 [details] > Patch > > What about PushButtonPart and InnerSpinButtonPart? They still both use a > font-sized-based heuristic. Is that still valuable? The heuristic is still valuable for PushButtonPart and InnerSpinButtonPart. Similar to checkboxes and radio buttons, the rounded button (PushButtonPart) and spin buttons (InnerSpinButtonPart) are restricted to fixed control sizes in AppKit. However, unlike checkboxes and radio buttons, these controls have actual dependencies on font-size. For the rounded buttons, we use larger AppKit control sizes as the font-size increases so that the text remains inside the button. Beyond a certain font-size, buttons begin to use AppKit’s square button appearance, which is not restricted to fixed sizes. For spin buttons (the stepper in <input type=number>) the heuristic is also needed, since they are inside a text box which resizes based on the font-size. The heuristic ensures the stepper fits the text box.
EWS
Comment 8 2022-01-07 09:34:06 PST
Committed r287753 (245816@main): <https://commits.webkit.org/245816@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448511 [details].
Note You need to log in before you can comment on or make changes to this bug.