Summary: | Make WebResourceLoadStatisticsStore a MessageReceiver | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||
Status: | NEW --- | ||||||||||||||
Severity: | Normal | CC: | annulen, darin, ews-watchlist, gyuyoung.kim, hi, mkwst, ryuan.choi, sergio, webkit-bug-importer, wilander | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Alex Christensen
2022-01-05 11:29:23 PST
Created attachment 448413 [details]
Patch
Created attachment 448414 [details]
Patch
Created attachment 448415 [details]
Patch
Comment on attachment 448415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448415&action=review r=me bar addressing the test failures. > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:-85 > -void WebResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned(bool value) Was this intentionally deleted? Doesn't seem to be part of the gist of this patch. A comment on why it can be removed would be good. > Source/WebKit/NetworkProcess/NetworkProcess.cpp:539 > void NetworkProcess::updatePrevalentDomainsToBlockCookiesFor(PAL::SessionID sessionID, const Vector<RegistrableDomain>& domainsToBlock, CompletionHandler<void()>&& completionHandler) Was this particular one not moved? > Source/WebKit/NetworkProcess/NetworkProcess.cpp:684 > +void NetworkProcess::setShouldEnableSameSiteStrictEnforcementForTesting(PAL::SessionID sessionID, WebCore::SameSiteStrictEnforcementEnabled enabled, CompletionHandler<void()>&& completionHandler) Nice catch. > Source/WebKit/UIProcess/WebPageProxy.cpp:5572 > + websiteDataStore().networkProcess().send(Messages::WebResourceLoadStatisticsStore::LogFrameNavigation(RegistrableDomain { targetURL }, RegistrableDomain { pageURL }, RegistrableDomain { sourceURL }, isRedirect, frame.isMainFrame(), MonotonicTime::now() - m_didFinishDocumentLoadForMainFrameTimestamp, wasPotentiallyInitiatedByUser), sessionID().toUInt64()); Would be nice to be able to send session ID objects directly. (In reply to John Wilander from comment #4) > Comment on attachment 448415 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448415&action=review > > r=me bar addressing the test failures. > > > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:-85 > > -void WebResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned(bool value) > > Was this intentionally deleted? Doesn't seem to be part of the gist of this > patch. A comment on why it can be removed would be good. It was dead code. Will note in change log. > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:539 > > void NetworkProcess::updatePrevalentDomainsToBlockCookiesFor(PAL::SessionID sessionID, const Vector<RegistrableDomain>& domainsToBlock, CompletionHandler<void()>&& completionHandler) > > Was this particular one not moved? I only moved the ones that were straightforwardly doing nothing but finding the WebResourceLoadStatisticsStore and forwarding parameters to it. This one goes to the NetworkStorageSession, so it'll be moved in a different patch. Created attachment 448457 [details]
Patch
Created attachment 448458 [details]
Patch
Comment on attachment 448458 [details]
Patch
TestWebKitAPI.ResourceLoadStatistics.DataSummaryWithCachedProcess test is failing
|