Bug 234884

Summary:

ServiceWorkerNavigationPreloader::didComplete should make sure to call its bodyCallback

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description youenn fablet 2022-01-05 08:28:11 PST

ServiceWorkerNavigationPreloader::didComplete should make sure to call its bodyCallback

Comment 1 Radar WebKit Bug Importer 2022-01-05 08:30:55 PST

<rdar://problem/87146589>

Comment 2 youenn fablet 2022-01-05 08:33:05 PST

Created attachment 448391 [details]
Patch

Comment 3 Alex Christensen 2022-01-05 11:43:58 PST

Comment on attachment 448391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448391&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp:207
> +    // After that point, |this| might be destroyed.

which point?
"After calling responseCallback, |this| may be destroyed."

Comment 4 youenn fablet 2022-01-06 01:27:31 PST

Created attachment 448470 [details]
Patch for landing

Comment 5 EWS 2022-01-06 02:24:53 PST

Committed r287676 (245773@main): <https://commits.webkit.org/245773@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448470 [details].