Bug 234870

Summary: [Win][DumpRenderTree] dumpHistoryItem leaks a SafeArray
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Tools / TestsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, don.olmstead, Hironori.Fujii, pvollan, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Fujii Hironori 2022-01-04 22:38:14 PST 
[Win][DumpRenderTree] dumpHistoryItem leaks a SafeArray

r23462 added the following code.

> if (arrPtr && SUCCEEDED(::SafeArrayUnlock(arrPtr)))
>     ::SafeArrayDestroy(arrPtr);

However, the array isn't locked. Thus, SafeArrayUnlock fails.
SafeArrayDestroy isn't called.
Comment 1 Fujii Hironori 2022-01-04 22:42:50 PST 
r23321 added the code.
Comment 2 Fujii Hironori 2022-01-04 22:52:20 PST 
Created attachment 448360 [details]
Patch
Comment 3 EWS 2022-01-05 00:03:55 PST 
Committed r287605 (245732@main): <https://commits.webkit.org/245732@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448360 [details].
Comment 4 Radar WebKit Bug Importer 2022-01-05 00:04:31 PST 
<rdar://problem/87133401>