Bug 23487

Summary: Eliminate the borderTopExtra lie from RenderBox::y()
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: TablesAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch that not only passes but also progresses layout tests :) oliver: review+

Description Dave Hyatt 2009-01-22 17:23:58 PST
Rework table cells so that the y() coordinate never lies.
Comment 1 Dave Hyatt 2009-01-22 18:41:04 PST
Created attachment 26950 [details]
Patch that not only passes but also progresses layout tests :)
Comment 2 Oliver Hunt 2009-01-22 19:00:50 PST
Comment on attachment 26950 [details]
Patch that not only passes but also progresses layout tests :)

r=me, afaict this looks like it should help perf, but maybe i'm mistaken.  anyhoo, r=me is conditional on perf being good.

also looking at the bit fields for m_intrinsicPaddingTop, m_intrinsicPaddingBottom, and m_widthChanged -- i think we should look at rearranging these to place n_widthChanged first, to reduce the liklihood that we'll end up with either horrific load alignment and/or an unnecessary word being added to RenderTableCell
Comment 3 Dave Hyatt 2009-01-22 19:48:29 PST
Fixed.