Bug 234814

Summary:

[PAS] constant-logical-operand clang warnings

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

WebKit Misc.

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrobinson, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Philippe Normand 2022-01-03 05:22:16 PST

/app/webkit/WebKitBuild/Release/bmalloc/Headers/bmalloc/pas_utils.h:583:12: warning: use of logical '||' with constant operand [-Wconstant-logical-operand]
    if ((0 || 0))
           ^  ~
/app/webkit/WebKitBuild/Release/bmalloc/Headers/bmalloc/pas_utils.h:583:12: note: use '|' for a bitwise operation

Comment 1 Philippe Normand 2022-01-03 05:24:41 PST

Created attachment 448228 [details]
Patch

Comment 2 Martin Robinson 2022-01-04 04:31:20 PST

Comment on attachment 448228 [details]
Patch

This seems pretty reasonable to me.

Comment 3 EWS 2022-01-04 05:06:40 PST

Committed r287562 (245697@main): <https://commits.webkit.org/245697@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448228 [details].

Comment 4 Radar WebKit Bug Importer 2022-01-04 05:07:20 PST

<rdar://problem/87086807>