Bug 234804

Summary: Delete most code for beforeload event
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, calvaris, cdumez, changseok, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, japhet, jer.noble, kangil.han, koivisto, kondapallykalyan, mifenton, pdr, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
cleanup
none
Updated for ToT
none
Fixed the test
none
Fixed the test
none
Patch koivisto: review+

Description Ryosuke Niwa 2022-01-02 17:20:03 PST 
Delete code for beforeload event.
The event has been disabled since https://trac.webkit.org/r261946.
Comment 1 Ryosuke Niwa 2022-01-02 17:35:05 PST 
Created attachment 448193 [details]
cleanup
Comment 2 Ryosuke Niwa 2022-01-02 17:48:23 PST 
Created attachment 448195 [details]
Updated for ToT
Comment 3 Ryosuke Niwa 2022-01-02 21:27:28 PST 
There is an existing bug in RenderImage::paintReplaced. Fixing that.
Comment 4 Ryosuke Niwa 2022-01-02 21:28:39 PST 
Created attachment 448203 [details]
Fixed the test
Comment 5 Ryosuke Niwa 2022-01-02 21:28:53 PST 
Comment on attachment 448203 [details]
Fixed the test

Wait for EWS.
Comment 6 Ryosuke Niwa 2022-01-02 23:22:10 PST 
Created attachment 448211 [details]
Fixed the test
Comment 7 Radar WebKit Bug Importer 2022-01-09 17:21:18 PST 
<rdar://problem/87317502>
Comment 8 Ryosuke Niwa 2022-01-28 22:26:22 PST 
Comment on attachment 448211 [details]
Fixed the test

I guess I need to go with a more conservative approach.
Comment 9 Ryosuke Niwa 2022-01-29 01:02:06 PST 
Created attachment 450322 [details]
Patch
Comment 10 Antti Koivisto 2022-01-29 02:38:21 PST 
nice!
Comment 11 Ryosuke Niwa 2022-01-29 13:01:07 PST 
Committed r288793 (246570@trunk): <https://commits.webkit.org/246570@trunk>