Summary: | Add missing method stubs to BackForwardListChromium | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 23384 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2009-01-22 10:35:41 PST
Created attachment 26931 [details]
v1 submitted for review
WebCore/history/BackForwardListChromium.cpp | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
Created attachment 26932 [details]
v1 submitted for review
WebCore/ChangeLog | 11 +++++++++++
WebCore/history/BackForwardListChromium.cpp | 12 ++++++++++++
2 files changed, 23 insertions(+), 0 deletions(-)
Comment on attachment 26932 [details]
v1 submitted for review
Darin Fisher and I discussed leaving out unneeded functions intentionally, using the linker to find the error.
Since you're submitting a patch to add these back, I guess there must be some code that's calling these. So I don't understand why ASSERT_NOT_REACHED is OK.
You should check with Darin. But r=me
Hi Darin, see comment #0. It turns out that two of the "not reached" methods are needed because they are referenced by other code that we compile. See Page::goBack() and Page::goForward(). So, the linker requires us to define those methods. However, goBack and goForward are never called by WebCore or our WebKit layer, so we can get away with not implementing them. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/history/BackForwardListChromium.cpp Committed r40249 http://trac.webkit.org/changeset/40249. |