Bug 234794

Summary: [JSC] Use emitPutProperty / emitGetPropertyValue consistently to handle private names in edge cases
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, sbarati, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ashvayka: review+

Description Yusuke Suzuki 2022-01-02 03:52:50 PST
[JSC] Use emitPutProperty / emitGetPropertyValue consistently to handle private names in edge cases
Comment 1 Yusuke Suzuki 2022-01-02 03:53:31 PST
Created attachment 448173 [details]
Patch
Comment 2 Alexey Shvayka 2022-01-02 08:09:14 PST
Comment on attachment 448173 [details]
Patch

This is super neat!

Could you please check if the same change is necessary for ShortCircuitReadModifyDotNode::emitBytecode()? Related nodes (AssignDotNode, ReadModifyDotNode) all perform emitPutProperty / emitGetPropertyValue.
Comment 3 Yusuke Suzuki 2022-01-02 23:08:45 PST
(In reply to Alexey Shvayka from comment #2)
> Comment on attachment 448173 [details]
> Patch
> 
> This is super neat!
> 
> Could you please check if the same change is necessary for
> ShortCircuitReadModifyDotNode::emitBytecode()? Related nodes (AssignDotNode,
> ReadModifyDotNode) all perform emitPutProperty / emitGetPropertyValue.

Nice, added.
Comment 4 Yusuke Suzuki 2022-01-02 23:39:48 PST
Committed r287531 (245666@trunk): <https://commits.webkit.org/245666@trunk>
Comment 5 Radar WebKit Bug Importer 2022-01-02 23:40:20 PST
<rdar://problem/87059955>