| Summary: | [Web Animations] getKeyframes() should return an empty object when there are no animatable properties in @keyframes rule | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, kondapallykalyan, pdr, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar, WebExposed | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 235138 | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2022-01-02 03:37:00 PST
Created attachment 448172 [details]
Patch
Comment on attachment 448172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448172&action=review > Source/WebCore/rendering/style/KeyframeList.cpp:139 > + for (auto cssPropertyId : m_properties) { > + if (CSSPropertyAnimation::isPropertyAnimatable(cssPropertyId)) > + return true; Shame there isn't the equivalent of Array.some on Vector. Committed r287517 (245652@main): <https://commits.webkit.org/245652@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448172 [details]. |