Bug 234793

Summary: [Web Animations] getKeyframes() should return an empty object when there are no animatable properties in @keyframes rule
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, kondapallykalyan, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 235138    
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2022-01-02 03:37:00 PST
[Web Animations] getKeyframes() should return an empty object when there are no animatable properties in @keyframes rule
Attachments
Patch (5.58 KB, patch)
2022-01-02 03:39 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2022-01-02 03:39:15 PST
Created attachment 448172 [details] Patch
Dean Jackson
Comment 2 2022-01-02 07:00:22 PST
Comment on attachment 448172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448172&action=review > Source/WebCore/rendering/style/KeyframeList.cpp:139 > + for (auto cssPropertyId : m_properties) { > + if (CSSPropertyAnimation::isPropertyAnimatable(cssPropertyId)) > + return true; Shame there isn't the equivalent of Array.some on Vector.
EWS
Comment 3 2022-01-02 08:13:46 PST
Committed r287517 (245652@main): <https://commits.webkit.org/245652@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448172 [details].
Radar WebKit Bug Importer
Comment 4 2022-01-02 08:14:27 PST
<rdar://problem/87049042>
Note You need to log in before you can comment on or make changes to this bug.