Bug 234720

Summary: [selectors] Import two :focus-visible tests from WPT
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: New BugsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, svillar, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2021-12-28 00:28:54 PST
[selectors] Import two :focus-visible tests from WPT
Attachments
Patch (10.76 KB, patch)
2021-12-28 00:29 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (11.12 KB, patch)
2021-12-28 00:31 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (9.32 KB, patch)
2021-12-28 03:52 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2021-12-28 00:29:49 PST
Created attachment 448038 [details] Patch
Manuel Rego Casasnovas
Comment 2 2021-12-28 00:31:46 PST
Created attachment 448039 [details] Patch
Sergio Villar Senin
Comment 3 2021-12-28 03:50:09 PST
Comment on attachment 448039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448039&action=review > LayoutTests/ChangeLog:8 > + Skip the new imported tests as they fail due to webkit.org/b/234139. IMO you either skip them and add valid expectations or do not skip them and use FAIL expectations.
Manuel Rego Casasnovas
Comment 4 2021-12-28 03:52:18 PST
Created attachment 448042 [details] Patch
Manuel Rego Casasnovas
Comment 5 2021-12-28 03:58:02 PST
(In reply to Sergio Villar Senin from comment #3) > Comment on attachment 448039 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448039&action=review > > > LayoutTests/ChangeLog:8 > > + Skip the new imported tests as they fail due to webkit.org/b/234139. > > IMO you either skip them and add valid expectations or do not skip them and > use FAIL expectations. Yes, I removed the -expected.txt files. Thanks for the review.
EWS
Comment 6 2021-12-28 04:29:40 PST
Committed r287469 (245604@main): <https://commits.webkit.org/245604@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448042 [details].
Radar WebKit Bug Importer
Comment 7 2021-12-28 04:30:17 PST
<rdar://problem/86955347>
Note You need to log in before you can comment on or make changes to this bug.