Summary: | [selectors] Import two :focus-visible tests from WPT | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||
Component: | New Bugs | Assignee: | Manuel Rego Casasnovas <rego> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | clopez, ews-watchlist, svillar, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2021-12-28 00:28:54 PST
Created attachment 448038 [details]
Patch
Created attachment 448039 [details]
Patch
Comment on attachment 448039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448039&action=review > LayoutTests/ChangeLog:8 > + Skip the new imported tests as they fail due to webkit.org/b/234139. IMO you either skip them and add valid expectations or do not skip them and use FAIL expectations. Created attachment 448042 [details]
Patch
(In reply to Sergio Villar Senin from comment #3) > Comment on attachment 448039 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448039&action=review > > > LayoutTests/ChangeLog:8 > > + Skip the new imported tests as they fail due to webkit.org/b/234139. > > IMO you either skip them and add valid expectations or do not skip them and > use FAIL expectations. Yes, I removed the -expected.txt files. Thanks for the review. Committed r287469 (245604@main): <https://commits.webkit.org/245604@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448042 [details]. |