Bug 234711

Summary: Support color interpolation methods for CSS Gradients
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Screenshot of gradient variations
none
Gradient Playground
none
Patch none

Sam Weinig
Reported 2021-12-27 18:06:43 PST
Support gradient interpolation methods for CSS Gradients
Attachments
Patch (561.13 KB, patch)
2021-12-27 18:22 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Screenshot of gradient variations (1.03 MB, image/png)
2021-12-28 10:23 PST, Sam Weinig 		no flags
Details
Gradient Playground (2.69 KB, text/html)
2021-12-28 10:23 PST, Sam Weinig 		no flags
Details
Patch (385.15 KB, patch)
2021-12-28 11:35 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-12-27 18:22:51 PST
Created attachment 448016 [details] Patch
Sam Weinig
Comment 2 2021-12-27 18:23:26 PST
No rendering tests yet, as those are proving tricky. Only parsing and serialization tests so far.
EWS Watchlist
Comment 3 2021-12-27 18:24:10 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Sam Weinig
Comment 4 2021-12-28 10:23:25 PST
Created attachment 448050 [details] Screenshot of gradient variations
Sam Weinig
Comment 5 2021-12-28 10:23:46 PST
Created attachment 448051 [details] Gradient Playground
Sam Weinig
Comment 6 2021-12-28 10:25:11 PST
Attached playground to test out gradients with all the different interpolation methods at once. (It requires the patch and setting enabled to work). Also added a screenshot of it working in MiniBrowser.
Simon Fraser (smfr)
Comment 7 2021-12-28 10:45:10 PST
Comment on attachment 448016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448016&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/gradient-interpolation-method-valid-expected.txt:2 > +FAIL e.style['background-image'] = "linear-gradient(in srgb, red, blue)" should set the property value assert_equals: serialization should be canonical expected "linear-gradient(in srgb, red, blue)" but got "linear-gradient(red, blue)" Why are these all fails?
Sam Weinig
Comment 8 2021-12-28 11:31:42 PST
(In reply to Simon Fraser (smfr) from comment #7) > Comment on attachment 448016 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448016&action=review > > > LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/gradient-interpolation-method-valid-expected.txt:2 > > +FAIL e.style['background-image'] = "linear-gradient(in srgb, red, blue)" should set the property value assert_equals: serialization should be canonical expected "linear-gradient(in srgb, red, blue)" but got "linear-gradient(red, blue)" > > Why are these all fails? Oh, cause I tried to simplify the test at the last moment and didn't double check things. I have the fix for this. Thanks for the review.
Sam Weinig
Comment 9 2021-12-28 11:35:49 PST
Created attachment 448054 [details] Patch
EWS
Comment 10 2021-12-28 12:37:35 PST
Committed r287474 (245609@main): <https://commits.webkit.org/245609@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448054 [details].
Radar WebKit Bug Importer
Comment 11 2021-12-28 12:38:20 PST
<rdar://problem/86963408>
Note You need to log in before you can comment on or make changes to this bug.