Bug 234691

Summary: Use StyleColor object instead of Color in WebCore
Product: WebKit Reporter: Sam Weinig <sam>
Component: CSSAssignee: Matthieu Dubet <m_dubet>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, emilio, ntim, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 245970    
Attachments:
Description Flags
Darin’s cut at part of the work for reference none

Description Sam Weinig 2021-12-26 10:38:08 PST 
The CSS 5 color mutation functions (color-mix(), color-contrast(), relative color syntax) don't work with currentcolor or system-colors as one of their origin colors.

This is due to the parser not being the right time to resolve those values, so some intermediate type is going to be needed to late resolve these things (perhaps time for a CSSColor object that can be resolved into a Color when appropriate).
Comment 1 Radar WebKit Bug Importer 2022-01-02 10:39:18 PST 
<rdar://problem/87050763>
Comment 2 Matthieu Dubet 2022-09-06 13:14:31 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4068
Comment 3 Darin Adler 2022-09-07 16:22:24 PDT 
I’m having trouble getting my work in progress pushed to GitHub, so I am going to attach a patch here. Matthieu mentioned he wanted to see my cut at this.
Comment 4 Darin Adler 2022-09-07 16:23:42 PDT 
Created attachment 462189 [details]
Darin’s cut at part of the work for reference
Comment 5 EWS 2022-10-03 12:14:11 PDT 
Committed 255095@main (b6c018250b04): <https://commits.webkit.org/255095@main>

Reviewed commits have been landed. Closing PR #4068 and removing active labels.