Summary: | Update wpt css/css-color tests | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | clopez, darin, ews-watchlist, gsnedders, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Sam Weinig
2021-12-25 17:55:24 PST
Created attachment 447964 [details]
Patch
Created attachment 447978 [details]
Patch
After this import, we can remove a few fast/css/ tests that will now be duplicates (or pretty much, I had to re-write as wpt, but the test cases are the same). Created attachment 447981 [details]
Patch
Unsure what our current policy on what to do with the -ref.html files is. Seems like it would be nice if we just supported that and didn't need our own -expected.html files. (In reply to Sam Weinig from comment #5) > Unsure what our current policy on what to do with the -ref.html files is. > > Seems like it would be nice if we just supported that and didn't need our > own -expected.html files. AFAIK The script to import the WPT tests will (in theory) automatically rename the -ref.html files to -expected.html ones There is some WIP patches at bug 204469 to support finding ref tests via rel=match attributes instead of relying on the filesystem My previous comment is incorrect, seems -ref.html suffix is supported like -expected.html Not sure if this has changed recently Created attachment 448004 [details]
Patch
Comment on attachment 448004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448004&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-computed.html:454 > + test_computed_value(`color`, `lch(from peru calc(l * 0.8) c h)`, `lch(49.80138% 54.003296 63.680317)`); Looks like this test is failing on GTK, somehow the floating point values are not serializing correctly. Need to expect that failure on that platform? Comment on attachment 448004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448004&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-valid.html:453 > + test_valid_value(`color`, `lch(from peru calc(l * 0.8) c h)`, `lch(49.80138% 54.003296 63.680317)`); Same thing here. Created attachment 448048 [details]
Patch
Committed r287473 (245608@main): <https://commits.webkit.org/245608@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448048 [details]. |