Bug 234677

Summary: Use ICU instead of relying on hard-coded string equality checks in ModalContainerControlClassifier
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch for landing none

Description Wenson Hsieh 2021-12-24 16:36:13 PST 
.
Comment 1 Wenson Hsieh 2021-12-24 16:48:53 PST 
Created attachment 447953 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-12-31 16:37:19 PST 
<rdar://problem/87036844>
Comment 3 Tim Horton 2022-01-04 14:32:18 PST 
Comment on attachment 447953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447953&action=review

> Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm:81
> +class ScopedSpoofChecker {

The word "Scoped" seems unnecessary? I don't think every RAII thing needs "Scoped" in the name. ScopedRefPtr?

Is just a SpoofChecker. Or StringSpoofChecker or something.
Comment 4 Wenson Hsieh 2022-01-04 14:33:34 PST 
Comment on attachment 447953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447953&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm:81
>> +class ScopedSpoofChecker {
> 
> The word "Scoped" seems unnecessary? I don't think every RAII thing needs "Scoped" in the name. ScopedRefPtr?
> 
> Is just a SpoofChecker. Or StringSpoofChecker or something.

Fair point — changed to just `SpoofChecker`
Comment 5 Wenson Hsieh 2022-01-04 15:03:11 PST 
Created attachment 448339 [details]
Patch for landing
Comment 6 EWS 2022-01-04 15:32:32 PST 
Committed r287592 (245721@main): <https://commits.webkit.org/245721@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448339 [details].