Bug 234677 – Use ICU instead of relying on hard-coded string equality checks in ModalContainerControlClassifier

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

.

[Wenson Hsieh]

Created attachment 447953 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/87036844>

[Tim Horton]

Comment on attachment 447953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447953&action=review

> Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm:81
> +class ScopedSpoofChecker {

The word "Scoped" seems unnecessary? I don't think every RAII thing needs "Scoped" in the name. ScopedRefPtr?

Is just a SpoofChecker. Or StringSpoofChecker or something.

[Wenson Hsieh]

Comment on attachment 447953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447953&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm:81
>> +class ScopedSpoofChecker {
> 
> The word "Scoped" seems unnecessary? I don't think every RAII thing needs "Scoped" in the name. ScopedRefPtr?
> 
> Is just a SpoofChecker. Or StringSpoofChecker or something.

Fair point — changed to just `SpoofChecker`

[Wenson Hsieh]

Created attachment 448339 [details]
Patch for landing

[EWS]

Committed r287592 (245721@main): <https://commits.webkit.org/245721@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448339 [details].