Bug 234677 - Use ICU instead of relying on hard-coded string equality checks in ModalContainerControlClassifier
Summary: Use ICU instead of relying on hard-coded string equality checks in ModalConta...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-24 16:36 PST by Wenson Hsieh
Modified: 2022-01-04 15:32 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.86 KB, patch)
2021-12-24 16:48 PST, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (6.71 KB, patch)
2022-01-04 15:03 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-12-24 16:36:13 PST 
.
Comment 1 Wenson Hsieh 2021-12-24 16:48:53 PST 
Created attachment 447953 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-12-31 16:37:19 PST 
<rdar://problem/87036844>
Comment 3 Tim Horton 2022-01-04 14:32:18 PST 
Comment on attachment 447953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447953&action=review

> Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm:81
> +class ScopedSpoofChecker {

The word "Scoped" seems unnecessary? I don't think every RAII thing needs "Scoped" in the name. ScopedRefPtr?

Is just a SpoofChecker. Or StringSpoofChecker or something.
Comment 4 Wenson Hsieh 2022-01-04 14:33:34 PST 
Comment on attachment 447953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447953&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm:81
>> +class ScopedSpoofChecker {
> 
> The word "Scoped" seems unnecessary? I don't think every RAII thing needs "Scoped" in the name. ScopedRefPtr?
> 
> Is just a SpoofChecker. Or StringSpoofChecker or something.

Fair point — changed to just `SpoofChecker`
Comment 5 Wenson Hsieh 2022-01-04 15:03:11 PST 
Created attachment 448339 [details]
Patch for landing
Comment 6 EWS 2022-01-04 15:32:32 PST 
Committed r287592 (245721@main): <https://commits.webkit.org/245721@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448339 [details].