Bug 234676

Summary: [LFC][IFC] Turn InlineContentBreaker::ContinuousContent's leading/trailing member variables to std::optional<InlineLayoutUnit>
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2021-12-24 15:38:07 PST
instead of using the magic value of 0.
Attachments
Patch (13.88 KB, patch)
2021-12-24 15:51 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.87 KB, patch)
2021-12-24 15:55 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.36 KB, patch)
2021-12-25 13:03 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.36 KB, patch)
2021-12-25 20:16 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-12-24 15:51:16 PST
Created attachment 447949 [details] Patch
alan
Comment 2 2021-12-24 15:55:27 PST
Created attachment 447950 [details] Patch
Antti Koivisto
Comment 3 2021-12-25 01:32:55 PST
Comment on attachment 447950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447950&action=review > Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:516 > - auto avilableWidth = std::max(0.0f, lineStatus.availableWidth - nonOverflowingContentWidth); > + auto avilableWidth = std::max(0.f, lineStatus.availableWidth - nonOverflowingContentWidth); "avilable" > Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:539 > - auto avilableWidth = std::max(0.0f, lineStatus.availableWidth - previousContentWidth); > + auto avilableWidth = std::max(0.f, lineStatus.availableWidth - previousContentWidth); here too
alan
Comment 4 2021-12-25 13:03:44 PST
Created attachment 447962 [details] Patch
alan
Comment 5 2021-12-25 20:16:45 PST
Created attachment 447967 [details] Patch
EWS
Comment 6 2021-12-25 22:17:33 PST
Committed r287442 (245577@main): <https://commits.webkit.org/245577@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447967 [details].
Radar WebKit Bug Importer
Comment 7 2021-12-25 22:18:16 PST
<rdar://problem/86910704>
Note You need to log in before you can comment on or make changes to this bug.