Bug 234676

Summary: [LFC][IFC] Turn InlineContentBreaker::ContinuousContent's leading/trailing member variables to std::optional<InlineLayoutUnit>
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2021-12-24 15:38:07 PST 
instead of using the magic value of 0.
Comment 1 zalan 2021-12-24 15:51:16 PST 
Created attachment 447949 [details]
Patch
Comment 2 zalan 2021-12-24 15:55:27 PST 
Created attachment 447950 [details]
Patch
Comment 3 Antti Koivisto 2021-12-25 01:32:55 PST 
Comment on attachment 447950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447950&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:516
> -    auto avilableWidth = std::max(0.0f, lineStatus.availableWidth - nonOverflowingContentWidth);
> +    auto avilableWidth = std::max(0.f, lineStatus.availableWidth - nonOverflowingContentWidth);

"avilable"

> Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:539
> -        auto avilableWidth = std::max(0.0f, lineStatus.availableWidth - previousContentWidth);
> +        auto avilableWidth = std::max(0.f, lineStatus.availableWidth - previousContentWidth);

here too
Comment 4 zalan 2021-12-25 13:03:44 PST 
Created attachment 447962 [details]
Patch
Comment 5 zalan 2021-12-25 20:16:45 PST 
Created attachment 447967 [details]
Patch
Comment 6 EWS 2021-12-25 22:17:33 PST 
Committed r287442 (245577@main): <https://commits.webkit.org/245577@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447967 [details].
Comment 7 Radar WebKit Bug Importer 2021-12-25 22:18:16 PST 
<rdar://problem/86910704>