Bug 234671

Summary:

[LFC][IFC] ContinuousContent should tell InlineContentBreaker if the candidate content is hanging

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2021-12-24 13:57:33 PST

ssia

Comment 1 zalan 2021-12-24 16:15:55 PST

Created attachment 447952 [details]
Patch

Comment 2 Antti Koivisto 2021-12-25 01:34:55 PST

Comment on attachment 447952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447952&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:207
> +        auto hangingContentWidth = [&]() -> std::optional<InlineLayoutUnit> {
> +            return isWhitespace && style.whiteSpace() == WhiteSpace::PreWrap ? std::make_optional(logicalWidth) : std::nullopt;
> +        };

maybe not to most necessary lambda

Comment 3 zalan 2021-12-26 06:34:39 PST

Created attachment 447972 [details]
Patch

Comment 4 EWS 2021-12-26 07:03:42 PST

Committed r287443 (245578@main): <https://commits.webkit.org/245578@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447972 [details].

Comment 5 Radar WebKit Bug Importer 2021-12-26 07:04:18 PST

<rdar://problem/86916610>