| Summary: | Re-enable WebPushD.HandleInjectedPush API test | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | beidson, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2021-12-22 19:06:28 PST
Created attachment 447851 [details]
Patch
Comment on attachment 447851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447851&action=review > Source/WebKit/webpushd/PushClientConnection.mm:83 > + // This isn't great, but currently the only user of webpushd in open source builds is TestWebKitAPI and codeSigningIdentifier returns the null String on x86_64 Macs. Is this comment accurate? Are AppleSilicon Macs really different? If so, the difference isn't reflected in this code. Comment on attachment 447851 [details]
Patch
The comment seems to be true, but this code makes all Macs behave the same when not using the internal SDK, independent of CPU architecture.
Committed r287384 (245524@main): <https://commits.webkit.org/245524@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447851 [details]. |