Bug 234627

Summary: Re-enable WebPushD.HandleInjectedPush API test
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2021-12-22 19:06:28 PST
Re-enable WebPushD.HandleInjectedPush API test
Attachments
Patch (3.91 KB, patch)
2021-12-22 19:10 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-12-22 19:10:27 PST
Created attachment 447851 [details] Patch
Brady Eidson
Comment 2 2021-12-22 21:03:56 PST
Comment on attachment 447851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447851&action=review > Source/WebKit/webpushd/PushClientConnection.mm:83 > + // This isn't great, but currently the only user of webpushd in open source builds is TestWebKitAPI and codeSigningIdentifier returns the null String on x86_64 Macs. Is this comment accurate? Are AppleSilicon Macs really different? If so, the difference isn't reflected in this code.
Alex Christensen
Comment 3 2021-12-22 22:35:51 PST
Comment on attachment 447851 [details] Patch The comment seems to be true, but this code makes all Macs behave the same when not using the internal SDK, independent of CPU architecture.
EWS
Comment 4 2021-12-22 23:01:27 PST
Committed r287384 (245524@main): <https://commits.webkit.org/245524@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447851 [details].
Radar WebKit Bug Importer
Comment 5 2021-12-22 23:02:16 PST
<rdar://problem/86840145>
Note You need to log in before you can comment on or make changes to this bug.