Bug 234619

Summary: Hardening: decodeArrayBuffer is missing WARN_UNUSED_RETURN
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, ews-watchlist, jiewen_tan, pascoe
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2021-12-22 14:29:10 PST
We recently noticed that the template function decodeArrayBuffer is missing WARN_UNUSED_RETURN. This patch just adds the declaration to help us avoid misusing the method.
Attachments
Patch (1.44 KB, patch)
2021-12-22 14:31 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2021-12-22 14:30:18 PST
<rdar://problem/62755159>
Brent Fulgham
Comment 2 2021-12-22 14:31:31 PST
Created attachment 447834 [details] Patch
Alex Christensen
Comment 3 2021-12-22 16:42:39 PST
Comment on attachment 447834 [details] Patch I see no reason not to do this.
Brent Fulgham
Comment 4 2021-12-22 17:11:08 PST
Comment on attachment 447834 [details] Patch Thank you for the review!
EWS
Comment 5 2021-12-22 17:49:33 PST
Committed r287380 (245520@main): <https://commits.webkit.org/245520@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447834 [details].
Note You need to log in before you can comment on or make changes to this bug.