Bug 234602

Summary: Internally unprefix -webkit-text-emphasis properties
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, koivisto, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+, ews-feeder: commit-queue-
Patch none

Tim Nguyen (:ntim)
Reported 2021-12-22 06:18:28 PST
It's already exposed unprefixed externally, let's reflect this internally as well. Makes it easier to remove prefixed versions later on if needed, and it's also less confusing when going through the CSSProperties.json file.
Attachments
Patch (18.07 KB, patch)
2021-12-22 07:01 PST, Tim Nguyen (:ntim)
koivisto: review+
ews-feeder: commit-queue-
Patch (32.66 KB, patch)
2021-12-22 08:55 PST, Tim Nguyen (:ntim)
no flags
Tim Nguyen (:ntim)
Comment 1 2021-12-22 07:01:13 PST
Tim Nguyen (:ntim)
Comment 2 2021-12-22 08:55:18 PST
Tim Nguyen (:ntim)
Comment 3 2021-12-22 08:58:02 PST
Radar WebKit Bug Importer
Comment 4 2021-12-22 08:58:17 PST
Tim Nguyen (:ntim)
Comment 5 2021-12-23 09:56:12 PST
Test gardening for ios done in: https://commits.webkit.org/r287403
Darin Adler
Comment 6 2021-12-24 09:19:30 PST
Comment on attachment 447806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447806&action=review > Source/WebCore/style/StyleBuilderCustom.h:115 > - DECLARE_PROPERTY_CUSTOM_HANDLERS(WebkitTextEmphasisStyle); > + DECLARE_PROPERTY_CUSTOM_HANDLERS(TextEmphasisStyle); Should we sort this one?
Tim Nguyen (:ntim)
Comment 7 2021-12-24 12:20:52 PST
(In reply to Darin Adler from comment #6) > Comment on attachment 447806 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447806&action=review > > > Source/WebCore/style/StyleBuilderCustom.h:115 > > - DECLARE_PROPERTY_CUSTOM_HANDLERS(WebkitTextEmphasisStyle); > > + DECLARE_PROPERTY_CUSTOM_HANDLERS(TextEmphasisStyle); > > Should we sort this one? Fixed in https://commits.webkit.org/r287430
Note You need to log in before you can comment on or make changes to this bug.