Bug 234602

Summary:

Internally unprefix -webkit-text-emphasis properties

Product:

WebKit

Reporter:

Tim Nguyen (:ntim) <ntim>

Component:

CSS

Assignee:

Tim Nguyen (:ntim) <ntim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, koivisto, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+, ews-feeder: commit-queue-
Patch	none

Description Tim Nguyen (:ntim) 2021-12-22 06:18:28 PST

It's already exposed unprefixed externally, let's reflect this internally as well.
Makes it easier to remove prefixed versions later on if needed, and it's also less confusing when going through the CSSProperties.json file.

Comment 1 Tim Nguyen (:ntim) 2021-12-22 07:01:13 PST

Created attachment 447803 [details]
Patch

Comment 2 Tim Nguyen (:ntim) 2021-12-22 08:55:18 PST

Created attachment 447806 [details]
Patch

Comment 3 Tim Nguyen (:ntim) 2021-12-22 08:58:02 PST

Committed r287356 (245498@trunk): <https://commits.webkit.org/245498@trunk>

Comment 4 Radar WebKit Bug Importer 2021-12-22 08:58:17 PST

<rdar://problem/86813136>

Comment 5 Tim Nguyen (:ntim) 2021-12-23 09:56:12 PST

Test gardening for ios done in: https://commits.webkit.org/r287403

Comment 6 Darin Adler 2021-12-24 09:19:30 PST

Comment on attachment 447806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447806&action=review

> Source/WebCore/style/StyleBuilderCustom.h:115
> -    DECLARE_PROPERTY_CUSTOM_HANDLERS(WebkitTextEmphasisStyle);
> +    DECLARE_PROPERTY_CUSTOM_HANDLERS(TextEmphasisStyle);

Should we sort this one?

Comment 7 Tim Nguyen (:ntim) 2021-12-24 12:20:52 PST

(In reply to Darin Adler from comment #6)
> Comment on attachment 447806 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447806&action=review
> 
> > Source/WebCore/style/StyleBuilderCustom.h:115
> > -    DECLARE_PROPERTY_CUSTOM_HANDLERS(WebkitTextEmphasisStyle);
> > +    DECLARE_PROPERTY_CUSTOM_HANDLERS(TextEmphasisStyle);
> 
> Should we sort this one?

Fixed in https://commits.webkit.org/r287430