Bug 234584

Summary: [iOS] Scroll view pinch zoom gesture sometimes fails to recognize in WKWebView
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: UI EventsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, hi, megan_gardner, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
For EWS
none
With test
none
For landing none

Description Wenson Hsieh 2021-12-21 18:19:58 PST 
rdar://84379650
Comment 1 Wenson Hsieh 2021-12-21 18:23:09 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-12-22 09:08:15 PST 
Created attachment 447807 [details]
With test
Comment 3 Simon Fraser (smfr) 2021-12-22 10:22:26 PST 
Comment on attachment 447807 [details]
With test

View in context: https://bugs.webkit.org/attachment.cgi?id=447807&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2024
> +    for (WKDeferringGestureRecognizer *gesture in self._touchStartDeferringGestures) {

I would call "gesture" "recognizer" here.
Comment 4 Wenson Hsieh 2021-12-22 10:24:32 PST 
Comment on attachment 447807 [details]
With test

View in context: https://bugs.webkit.org/attachment.cgi?id=447807&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2024
>> +    for (WKDeferringGestureRecognizer *gesture in self._touchStartDeferringGestures) {
> 
> I would call "gesture" "recognizer" here.

Sounds good — renamed the local variable to `gestureRecognizer`.
Comment 5 Wenson Hsieh 2021-12-22 10:28:59 PST 
Created attachment 447816 [details]
For landing
Comment 6 EWS 2021-12-22 11:13:49 PST 
Committed r287366 (245508@main): <https://commits.webkit.org/245508@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447816 [details].