| Summary: | Web Inspector: Assertion Failed adding event listener in CSSPropertyNameCompletions.prototype._updateValuesWithLatestCSSVariablesIfNeeded | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick Angle <pangle> | ||||
| Component: | Web Inspector | Assignee: | Patrick Angle <pangle> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 447736 [details]
Patch v1.0
Comment on attachment 447736 [details]
Patch v1.0
r=me, this is perhaps maybe slightly more inefficient cause we're now listening for `WI.DOMNodeStyles.Event.NeedsRefresh` even if we haven't called `allCSSVariables` yet, but I think it's fine
Committed r287338 (245480@main): <https://commits.webkit.org/245480@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447736 [details]. |
From Devin: [Error] Assertion Failed (4) DOMNodeStyles "dom-node-styles-needs-refresh" function _handleNodesStylesNeedsRefresh(event) { this._needsVariablesFromInspectedNode = true; } CSSPropertyNameCompletions addEventListener (Object.js:53) _updateValuesWithLatestCSSVariablesIfNeeded (CSSPropertyNameCompletions.js:90) executeQuery (CSSPropertyNameCompletions.js:59) (anonymous function) (CSSKeywordCompletions.js:48) _nameCompletionDataProvider _updateCompletions (SpreadsheetTextField.js:436) _handleInput (SpreadsheetTextField.js:423) _handleInput Currently we continually add event listeners every time we update the completions. We should only add/remove this listener on a node changing.