Bug 234570 – Web Inspector: Assertion Failed adding event listener in CSSPropertyNameCompletions.prototype._updateValuesWithLatestCSSVariablesIfNeeded

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Patrick Angle]

From Devin:
[Error] Assertion Failed (4)
DOMNodeStyles
"dom-node-styles-needs-refresh"
function _handleNodesStylesNeedsRefresh(event) { this._needsVariablesFromInspectedNode = true; }
CSSPropertyNameCompletions
	addEventListener (Object.js:53)
	_updateValuesWithLatestCSSVariablesIfNeeded (CSSPropertyNameCompletions.js:90)
	executeQuery (CSSPropertyNameCompletions.js:59)
	(anonymous function) (CSSKeywordCompletions.js:48)
	_nameCompletionDataProvider
	_updateCompletions (SpreadsheetTextField.js:436)
	_handleInput (SpreadsheetTextField.js:423)
	_handleInput

Currently we continually add event listeners every time we update the completions. We should only add/remove this listener on a node changing.

[Radar WebKit Bug Importer]

<rdar://problem/86776737>

[Patrick Angle]

Created attachment 447736 [details]
Patch v1.0

[Devin Rousso]

Comment on attachment 447736 [details]
Patch v1.0

r=me, this is perhaps maybe slightly more inefficient cause we're now listening for `WI.DOMNodeStyles.Event.NeedsRefresh` even if we haven't called `allCSSVariables` yet, but I think it's fine

[EWS]

Committed r287338 (245480@main): <https://commits.webkit.org/245480@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447736 [details].