Bug 234570 - Web Inspector: Assertion Failed adding event listener in CSSPropertyNameCompletions.prototype._updateValuesWithLatestCSSVariablesIfNeeded
Summary: Web Inspector: Assertion Failed adding event listener in CSSPropertyNameCompl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-21 11:01 PST by Patrick Angle
Modified: 2021-12-21 17:40 PST (History)
4 users (show)

See Also:

Attachments
Patch v1.0 (3.22 KB, patch)
2021-12-21 11:07 PST, Patrick Angle 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-12-21 11:01:41 PST 
From Devin:
[Error] Assertion Failed (4)
DOMNodeStyles
"dom-node-styles-needs-refresh"
function _handleNodesStylesNeedsRefresh(event) { this._needsVariablesFromInspectedNode = true; }
CSSPropertyNameCompletions
	addEventListener (Object.js:53)
	_updateValuesWithLatestCSSVariablesIfNeeded (CSSPropertyNameCompletions.js:90)
	executeQuery (CSSPropertyNameCompletions.js:59)
	(anonymous function) (CSSKeywordCompletions.js:48)
	_nameCompletionDataProvider
	_updateCompletions (SpreadsheetTextField.js:436)
	_handleInput (SpreadsheetTextField.js:423)
	_handleInput

Currently we continually add event listeners every time we update the completions. We should only add/remove this listener on a node changing.
Comment 1 Radar WebKit Bug Importer 2021-12-21 11:01:52 PST 
<rdar://problem/86776737>
Comment 2 Patrick Angle 2021-12-21 11:07:08 PST 
Created attachment 447736 [details]
Patch v1.0
Comment 3 Devin Rousso 2021-12-21 11:12:18 PST 
Comment on attachment 447736 [details]
Patch v1.0

r=me, this is perhaps maybe slightly more inefficient cause we're now listening for `WI.DOMNodeStyles.Event.NeedsRefresh` even if we haven't called `allCSSVariables` yet, but I think it's fine
Comment 4 EWS 2021-12-21 17:40:40 PST 
Committed r287338 (245480@main): <https://commits.webkit.org/245480@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447736 [details].