Bug 234565

Summary: PCM tests crashing with 'unlink' errors
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Kate Cheney 2021-12-21 09:09:58 PST 
PCM tests are crashing in various places with file unlink errors, which usually occur when trying to delete a database that is still open.
Comment 1 Radar WebKit Bug Importer 2021-12-21 09:10:18 PST 
<rdar://problem/86771766>
Comment 2 Kate Cheney 2021-12-21 09:20:28 PST 
Created attachment 447723 [details]
Patch
Comment 3 Kate Cheney 2021-12-21 11:26:11 PST 
Created attachment 447737 [details]
Patch
Comment 4 Alex Christensen 2021-12-21 14:44:12 PST 
Comment on attachment 447737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447737&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:323
> +        EXPECT_FALSE([defaultFileManager fileExistsAtPath:itpRoot]);

This isn't necessary.  If we exited the while loop, we know it is false.
Comment 5 Kate Cheney 2021-12-22 13:23:36 PST 
Created attachment 447828 [details]
Patch for landing
Comment 6 EWS 2021-12-22 14:25:06 PST 
Committed r287371 (245512@main): <https://commits.webkit.org/245512@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447828 [details].