Bug 234547

Summary: [RISCV64] Add RISCV64 support in YARR
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, msaboff, pmatos, saam, tzagallo, webkit-bug-importer, xan.lopez, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237775    
Attachments:
Description Flags
Patch
none
Patch none

Description Zan Dobersek 2021-12-20 23:51:48 PST 
[RISCV64] Add RISCV64 support in YARR
Comment 1 Zan Dobersek 2021-12-20 23:53:01 PST 
Created attachment 447692 [details]
Patch
Comment 2 Yusuke Suzuki 2021-12-21 00:19:08 PST 
Comment on attachment 447692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447692&action=review

Nice

> Source/JavaScriptCore/ChangeLog:10
> +        with other 64-bit architectures.

I think you also need to flip some flags in PlatformEnable.h (YarrJIT feature flags for rich 64bit architectures. e.g. ENABLE_YARR_JIT_BACKREFERENCES).
Comment 3 Zan Dobersek 2021-12-22 01:26:02 PST 
Created attachment 447787 [details]
Patch
Comment 4 Yusuke Suzuki 2021-12-22 10:38:30 PST 
Comment on attachment 447787 [details]
Patch

r=me
Comment 5 EWS 2021-12-22 11:21:39 PST 
Committed r287367 (245509@main): <https://commits.webkit.org/245509@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447787 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-22 11:22:17 PST 
<rdar://problem/86819359>