Bug 234547 - [RISCV64] Add RISCV64 support in YARR
Summary: [RISCV64] Add RISCV64 support in YARR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 237775
  Show dependency tree / graph
 
Reported: 2021-12-20 23:51 PST by Zan Dobersek
Modified: 2022-03-11 05:33 PST (History)
13 users (show)

See Also:

Attachments
Patch (7.70 KB, patch)
2021-12-20 23:53 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (11.02 KB, patch)
2021-12-22 01:26 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2021-12-20 23:51:48 PST 
[RISCV64] Add RISCV64 support in YARR
Comment 1 Zan Dobersek 2021-12-20 23:53:01 PST 
Created attachment 447692 [details]
Patch
Comment 2 Yusuke Suzuki 2021-12-21 00:19:08 PST 
Comment on attachment 447692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447692&action=review

Nice

> Source/JavaScriptCore/ChangeLog:10
> +        with other 64-bit architectures.

I think you also need to flip some flags in PlatformEnable.h (YarrJIT feature flags for rich 64bit architectures. e.g. ENABLE_YARR_JIT_BACKREFERENCES).
Comment 3 Zan Dobersek 2021-12-22 01:26:02 PST 
Created attachment 447787 [details]
Patch
Comment 4 Yusuke Suzuki 2021-12-22 10:38:30 PST 
Comment on attachment 447787 [details]
Patch

r=me
Comment 5 EWS 2021-12-22 11:21:39 PST 
Committed r287367 (245509@main): <https://commits.webkit.org/245509@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447787 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-22 11:22:17 PST 
<rdar://problem/86819359>