Bug 234535

Summary: Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2021-12-20 15:59:30 PST
Momentum Event Dispatcher: Momentum tails may get truncated if the duration runs longer than the system's
Attachments
Patch (23.73 KB, patch)
2021-12-20 16:02 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (23.70 KB, patch)
2021-12-20 16:58 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (24.37 KB, patch)
2021-12-20 21:30 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (25.62 KB, patch)
2022-01-04 17:00 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (25.78 KB, patch)
2022-01-04 17:40 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (25.52 KB, patch)
2022-01-04 22:12 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2021-12-20 16:02:37 PST
Created attachment 447657 [details] Patch
Tim Horton
Comment 2 2021-12-20 16:02:40 PST
<rdar://problem/86338105>
Simon Fraser (smfr)
Comment 3 2021-12-20 16:13:02 PST
Comment on attachment 447657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447657&action=review > Source/WebKit/Shared/mac/WebEventFactory.mm:414 > + WallTime ioHIDEventWallTime = timestamp; auto > Source/WebKit/Shared/mac/WebEventFactory.mm:416 > + WebWheelEvent::MomentumEndType momentumEndType = WebWheelEvent::MomentumEndType::Unknown; auto
Tim Horton
Comment 4 2021-12-20 16:58:39 PST
Created attachment 447666 [details] Patch
Tim Horton
Comment 5 2021-12-20 21:30:34 PST
Created attachment 447687 [details] Patch
Tim Horton
Comment 6 2022-01-04 17:00:21 PST
Created attachment 448349 [details] Patch
Tim Horton
Comment 7 2022-01-04 17:40:15 PST
Created attachment 448353 [details] Patch
Darin Adler
Comment 8 2022-01-04 21:12:58 PST
Comment on attachment 448353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448353&action=review > Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h:30 > -#define ENABLE_MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING 0 > +#define ENABLE_MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING 1 Was this checked in by accident?
Tim Horton
Comment 9 2022-01-04 22:10:23 PST
(In reply to Darin Adler from comment #8) > Comment on attachment 448353 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448353&action=review > > > Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h:30 > > -#define ENABLE_MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING 0 > > +#define ENABLE_MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING 1 > > Was this checked in by accident? Good point, need to not accidentally revert r287578!
Tim Horton
Comment 10 2022-01-04 22:12:12 PST
Created attachment 448359 [details] Patch
EWS
Comment 11 2022-01-05 11:30:53 PST
Committed r287641 (245745@main): <https://commits.webkit.org/245745@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448359 [details].
Tim Horton
Comment 12 2022-01-05 13:58:47 PST
Build fix: https://trac.webkit.org/changeset/287651/webkit
Note You need to log in before you can comment on or make changes to this bug.