Bug 234519

Summary: [LFC][IFC] Decouple LineBox and InlineDisplay:Line construction
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2021-12-20 11:50:05 PST
While LineBox is all logical, InlineDisplay:Line is physical.
Comment 1 zalan 2021-12-20 11:52:37 PST
Created attachment 447616 [details]
Patch
Comment 2 Antti Koivisto 2021-12-20 11:58:43 PST
Comment on attachment 447616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447616&action=review

> Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.h:39
> +class InlineDisplayLineBuilder {

Builder is the official pattern of 2021.
Comment 3 EWS 2021-12-20 16:34:41 PST
Committed r287287 (245439@main): <https://commits.webkit.org/245439@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447616 [details].
Comment 4 Radar WebKit Bug Importer 2021-12-20 16:35:17 PST
<rdar://problem/86745474>