Bug 234506

Summary: [LCMS] Use std::unqiue_ptr to retain LCMS objects
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: WebCore Misc.Assignee: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, berto, cgarcia, don.olmstead, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233364
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Yoshiaki Jitsukawa
Reported 2021-12-20 00:29:29 PST
As pointed out on https://bugs.webkit.org/show_bug.cgi?id=233364#c7, I'd like to introduce LCMSUniqeptr to handle cmsHTRANSFORM and cmsHPROFILE.
Attachments
Patch (18.71 KB, patch)
2021-12-20 01:02 PST, Yoshiaki Jitsukawa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2021-12-20 01:02:04 PST
Created attachment 447590 [details] Patch
Michael Catanzaro
Comment 2 2021-12-20 07:24:43 PST
Comment on attachment 447590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447590&action=review > Source/WebCore/platform/graphics/lcms/LCMSUniquePtr.h:38 > + void operator() (cmsHPROFILE ptr) const Why do these have to be const?
Yoshiaki Jitsukawa
Comment 3 2021-12-21 01:34:34 PST
> Why do these have to be const? Hmm, I'm not sure it's necesarry to be const but following the signature of the default deleter: void operator()(T* ptr) const;
EWS
Comment 4 2021-12-21 02:07:30 PST
Committed r287306 (245458@main): <https://commits.webkit.org/245458@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447590 [details].
Radar WebKit Bug Importer
Comment 5 2021-12-21 02:08:14 PST
<rdar://problem/86760146>
Note You need to log in before you can comment on or make changes to this bug.