| Summary: | [LCMS] Use std::unqiue_ptr to retain LCMS objects | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||
| Component: | WebCore Misc. | Assignee: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, aperez, berto, cgarcia, don.olmstead, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=233364 | ||||||
| Attachments: |
|
||||||
|
Description
Yoshiaki Jitsukawa
2021-12-20 00:29:29 PST
Created attachment 447590 [details]
Patch
Comment on attachment 447590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447590&action=review > Source/WebCore/platform/graphics/lcms/LCMSUniquePtr.h:38 > + void operator() (cmsHPROFILE ptr) const Why do these have to be const? > Why do these have to be const?
Hmm, I'm not sure it's necesarry to be const but following the signature of the default deleter:
void operator()(T* ptr) const;
Committed r287306 (245458@main): <https://commits.webkit.org/245458@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447590 [details]. |