Bug 234505

Summary: [Win] MSVC reports "DragImageCairoWin.cpp(142): error C2362: initialization of 'cr' is skipped by 'goto exit'" with /std:c++20
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: PlatformAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 233448    
Attachments:
Description Flags
Patch
none
Patch none

Description Fujii Hironori 2021-12-19 22:28:26 PST
[Win] MSVC reports "DragImageCairoWin.cpp(142): error C2362: initialization of 'cr' is skipped by 'goto exit'" with /std:c++20

> Source\WebCore\platform\win\DragImageCairoWin.cpp(142): error C2362: initialization of 'cr' is skipped by 'goto exit'
> Source\WebCore\platform\win\DragImageCairoWin.cpp(131): note: see declaration of 'cr'
> Source\WebCore\platform\win\DragImageCairoWin.cpp(142): note: see declaration of 'exit'
> Source\WebCore\platform\win\DragImageCairoWin.cpp(142): error C2362: initialization of 'srcImage' is skipped by 'goto exit'
> Source\WebCore\platform\win\DragImageCairoWin.cpp(126): note: see declaration of 'srcImage'
> Source\WebCore\platform\win\DragImageCairoWin.cpp(142): note: see declaration of 'exit'
Comment 1 Fujii Hironori 2021-12-19 22:30:43 PST
Created attachment 447585 [details]
Patch
Comment 2 Fujii Hironori 2021-12-19 22:40:25 PST
Created attachment 447586 [details]
Patch
Comment 3 Fujii Hironori 2021-12-20 11:55:03 PST
Comment on attachment 447586 [details]
Patch

Clearing flags on attachment: 447586

Committed r287268 (245424@trunk): <https://commits.webkit.org/245424@trunk>
Comment 4 Fujii Hironori 2021-12-20 11:55:07 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2021-12-20 11:56:23 PST
<rdar://problem/86734337>