Summary: | Add PAL soft linking headers for CoreML and NaturalLanguage frameworks | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | Platform | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | akeerthi, annulen, bdakin, dino, ews-watchlist, graouts, gyuyoung.kim, hi, megan_gardner, ryuan.choi, sergio, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 234322 | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2021-12-19 11:58:03 PST
Created attachment 447554 [details]
Patch
Created attachment 447555 [details]
Add missing file
Comment on attachment 447555 [details] Add missing file View in context: https://bugs.webkit.org/attachment.cgi?id=447555&action=review rs=me > Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:1535 > + F47221F3276FC2EB00B984C7 /* CoreMLSoftLink.h in Headers */, I think this is supposed to be the first of the `CoreM*` since the `L` is a capital and the rest are lowercase? Or do I have it backwards? > Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:1894 > + F47221F4276FC2EB00B984C7 /* CoreMLSoftLink.mm in Sources */, ditto (:1535) Comment on attachment 447555 [details] Add missing file View in context: https://bugs.webkit.org/attachment.cgi?id=447555&action=review >> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:1535 >> + F47221F3276FC2EB00B984C7 /* CoreMLSoftLink.h in Headers */, > > I think this is supposed to be the first of the `CoreM*` since the `L` is a capital and the rest are lowercase? Or do I have it backwards? Ah, I just used `sort-Xcode-project-file` for this, which appears to prefer this (case-insensitive) order. Since this runs automatically when using `webkit-patch upload`, I think we should follow the order that the script enforces. Committed r287273 (245429@main): <https://commits.webkit.org/245429@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447555 [details]. |