Bug 234489

Summary: Add PAL soft linking headers for CoreML and NaturalLanguage frameworks
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, annulen, bdakin, dino, ews-watchlist, graouts, gyuyoung.kim, hi, megan_gardner, ryuan.choi, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 234322    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Add missing file none

Wenson Hsieh
Reported 2021-12-19 11:58:03 PST
.
Attachments
Patch (13.96 KB, patch)
2021-12-19 12:06 PST, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Add missing file (16.46 KB, patch)
2021-12-19 12:14 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-12-19 12:06:41 PST Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2021-12-19 12:14:46 PST
Created attachment 447555 [details] Add missing file
Devin Rousso
Comment 3 2021-12-20 12:51:59 PST
Comment on attachment 447555 [details] Add missing file View in context: https://bugs.webkit.org/attachment.cgi?id=447555&action=review rs=me > Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:1535 > + F47221F3276FC2EB00B984C7 /* CoreMLSoftLink.h in Headers */, I think this is supposed to be the first of the `CoreM*` since the `L` is a capital and the rest are lowercase? Or do I have it backwards? > Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:1894 > + F47221F4276FC2EB00B984C7 /* CoreMLSoftLink.mm in Sources */, ditto (:1535)
Wenson Hsieh
Comment 4 2021-12-20 12:57:45 PST
Comment on attachment 447555 [details] Add missing file View in context: https://bugs.webkit.org/attachment.cgi?id=447555&action=review >> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:1535 >> + F47221F3276FC2EB00B984C7 /* CoreMLSoftLink.h in Headers */, > > I think this is supposed to be the first of the `CoreM*` since the `L` is a capital and the rest are lowercase? Or do I have it backwards? Ah, I just used `sort-Xcode-project-file` for this, which appears to prefer this (case-insensitive) order. Since this runs automatically when using `webkit-patch upload`, I think we should follow the order that the script enforces.
EWS
Comment 5 2021-12-20 13:03:51 PST
Committed r287273 (245429@main): <https://commits.webkit.org/245429@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447555 [details].
Radar WebKit Bug Importer
Comment 6 2021-12-20 13:04:18 PST
<rdar://problem/86737023>
Note You need to log in before you can comment on or make changes to this bug.