Bug 234489 - Add PAL soft linking headers for CoreML and NaturalLanguage frameworks
Summary: Add PAL soft linking headers for CoreML and NaturalLanguage frameworks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 234322
  Show dependency tree / graph
 
Reported: 2021-12-19 11:58 PST by Wenson Hsieh
Modified: 2021-12-20 13:04 PST (History)
13 users (show)

See Also:

Attachments
Patch (13.96 KB, patch)
2021-12-19 12:06 PST, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Add missing file (16.46 KB, patch)
2021-12-19 12:14 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-12-19 11:58:03 PST 
.
Comment 1 Wenson Hsieh 2021-12-19 12:06:41 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-12-19 12:14:46 PST 
Created attachment 447555 [details]
Add missing file
Comment 3 Devin Rousso 2021-12-20 12:51:59 PST 
Comment on attachment 447555 [details]
Add missing file

View in context: https://bugs.webkit.org/attachment.cgi?id=447555&action=review

rs=me

> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:1535
> +				F47221F3276FC2EB00B984C7 /* CoreMLSoftLink.h in Headers */,

I think this is supposed to be the first of the `CoreM*` since the `L` is a capital and the rest are lowercase?  Or do I have it backwards?

> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:1894
> +				F47221F4276FC2EB00B984C7 /* CoreMLSoftLink.mm in Sources */,

ditto (:1535)
Comment 4 Wenson Hsieh 2021-12-20 12:57:45 PST 
Comment on attachment 447555 [details]
Add missing file

View in context: https://bugs.webkit.org/attachment.cgi?id=447555&action=review

>> Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:1535
>> +				F47221F3276FC2EB00B984C7 /* CoreMLSoftLink.h in Headers */,
> 
> I think this is supposed to be the first of the `CoreM*` since the `L` is a capital and the rest are lowercase?  Or do I have it backwards?

Ah, I just used `sort-Xcode-project-file` for this, which appears to prefer this (case-insensitive) order.

Since this runs automatically when using `webkit-patch upload`, I think we should follow the order that the script enforces.
Comment 5 EWS 2021-12-20 13:03:51 PST 
Committed r287273 (245429@main): <https://commits.webkit.org/245429@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447555 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-20 13:04:18 PST 
<rdar://problem/86737023>