Bug 234488 – Preferences that read from NSUserDefaults need to be initialied from platformInitializeStore()

• Component: WebKit Misc.
• Status: ASSIGNED

[Simon Fraser (smfr)]

Preferences that read from NSUserDefaults need to be initialied from platformInitializeStore()

[Simon Fraser (smfr)]

Created attachment 447553 [details]
Patch

[Sam Weinig]

Comment on attachment 447553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447553&action=review

> Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm:143
> +void WebPreferences::initializePlatformDependentPreferences()

I don't think platform dependent is the right name, since everything in this file is platform dependent. Perhaps platformInitializeProcessStateDependentPreferences()?

> Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm:154
> +    m_store.setBoolValueForKey(WebPreferencesKey::scrollAnimatorEnabledKey(), [[NSUserDefaults standardUserDefaults] boolForKey:@"NSScrollAnimationEnabled"]);

I think you want to wrap this in #if PLATFORM(MAC)?

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/287364/webkit

[Radar WebKit Bug Importer]

<rdar://problem/86817858>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 234620