ASSIGNED234488
Preferences that read from NSUserDefaults need to be initialied from platformInitializeStore() 
https://bugs.webkit.org/show_bug.cgi?id=234488
Summary Preferences that read from NSUserDefaults need to be initialied from platform...
Simon Fraser (smfr)
Reported 2021-12-19 11:38:23 PST
Preferences that read from NSUserDefaults need to be initialied from platformInitializeStore()
Attachments
Patch (6.58 KB, patch)
2021-12-19 11:40 PST, Simon Fraser (smfr) 		sam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-12-19 11:40:20 PST
Created attachment 447553 [details] Patch
Sam Weinig
Comment 2 2021-12-20 15:55:56 PST
Comment on attachment 447553 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447553&action=review > Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm:143 > +void WebPreferences::initializePlatformDependentPreferences() I don't think platform dependent is the right name, since everything in this file is platform dependent. Perhaps platformInitializeProcessStateDependentPreferences()? > Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm:154 > + m_store.setBoolValueForKey(WebPreferencesKey::scrollAnimatorEnabledKey(), [[NSUserDefaults standardUserDefaults] boolForKey:@"NSScrollAnimationEnabled"]); I think you want to wrap this in #if PLATFORM(MAC)?
Simon Fraser (smfr)
Comment 3 2021-12-22 10:49:16 PST
https://trac.webkit.org/changeset/287364/webkit
Radar WebKit Bug Importer
Comment 4 2021-12-22 10:50:17 PST
<rdar://problem/86817858>
WebKit Commit Bot
Comment 5 2021-12-22 14:30:13 PST
Re-opened since this is blocked by bug 234620
Note You need to log in before you can comment on or make changes to this bug.