Bug 234458 – Don't pack audio samples with discontinuity together

• Component: Media
• Status: RESOLVED FIXED

[Jean-Yves Avenard [:jya]]

When playing https://jyavenard.github.io/htmltests/tests/mse_webm/83910012/ at 2s we can hear a "chtook" kind of sound.

This stream has a 1ms discontinuity after the first opus packet (20ms), as 2s worth of samples are packed together that discontinuity can be heard at the 2s block boundary.

We shouldn't pack samples together if there's a discontinuity between them so that timestamps stay correct.

[Radar WebKit Bug Importer]

<rdar://problem/86659914>

[Jean-Yves Avenard [:jya]]

Created attachment 447505 [details]
Patch

[Eric Carlson]

Comment on attachment 447505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447505&action=review

> Source/WebCore/ChangeLog:18
> +        So w no longer pack samples with discontinuities so that the frame

s/So w/So we/

> Source/WebCore/ChangeLog:23
> +        in CoreMedia that insert very audible artifacts when there's a gap between

s/insert/inserts/

[Jean-Yves Avenard [:jya]]

Created attachment 447560 [details]
Patch

address comments

[Jean-Yves Avenard [:jya]]

Created attachment 447561 [details]
Patch

add reviewer name

[EWS]

Committed r287249 (245407@main): <https://commits.webkit.org/245407@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447561 [details].