Bug 23445

Summary: Copying certain hidden text causes a crash
Product: WebKit Reporter: Tom Robinson <tom>
Component: HTML EditingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ianh, mrowe
Priority: P2 Keywords: InRadar, NeedsReduction
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
URL: http://www.reddit.com/r/apple/comments/7r3xu/how_to_crash_safari_1_select_text_from_a_comment/
Attachments:
Description Flags
patch mitz: review+

Tom Robinson
Reported 2009-01-20 20:33:45 PST
1) Login to reddit.com and visit a comments page 2) Select the text of a comment 3) Click the "[-]" widget for the selected comment to hide it 4) Try to copy the hidden text via keyboard shortcut or menu Note this only works if you're logged into reddit.com
Attachments
patch (4.86 KB, patch)
2009-03-29 18:24 PDT, Darin Adler 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2009-01-20 20:34:40 PST
<rdar://problem/6512520>
Mark Rowe (bdash)
Comment 2 2009-03-05 19:15:13 PST
*** Bug 24414 has been marked as a duplicate of this bug. ***
Darin Adler
Comment 3 2009-03-29 17:21:11 PDT
Darn, I wanted to work on this bug, but I don't have a reddit.com account. I guess I'll have to make one.
Darin Adler
Comment 4 2009-03-29 17:39:02 PDT
There are two aspects to this bug: 1) When the end points of the range are no longer rendered due to display: none, it would be good to update the selection so it doesn't include the invisible stuff. 2) When we actually run the createMarkup algorithm it would be best not to crash. I have a fix for (2) done. Next I'll make a regression test. Then I'll fix (1) as well.
Darin Adler
Comment 5 2009-03-29 18:24:49 PDT
Created attachment 29052 [details] patch
Darin Adler
Comment 6 2009-03-29 19:21:20 PDT
(In reply to comment #4) > 1) When the end points of the range are no longer rendered due to display: > none, it would be good to update the selection so it doesn't include the > invisible stuff. I decided not to fix this at this time. I'm not sure what behavior we want for this.
Darin Adler
Comment 7 2009-03-29 19:21:45 PDT
http://trac.webkit.org/changeset/42096
Note You need to log in before you can comment on or make changes to this bug.