Bug 234438

Summary: Hash tables, read/write, and heap memory are used unnecessarily, which may hurt performance
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andersca, andresg_22, apinheiro, benjamin, cdumez, cfleizach, changseok, cmarcelo, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, jcraig, jdiggs, jer.noble, kangil.han, kondapallykalyan, mifenton, mmaxfield, pdr, philipj, sabouhallawa, samuel_white, sam, schenney, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Darin Adler
Reported 2021-12-17 11:16:40 PST
Hash tables, read/write, and heap memory are used unnecessarily, which may hurt performance
Attachments
Patch (86.24 KB, patch)
2021-12-17 13:54 PST, Darin Adler 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (86.15 KB, patch)
2021-12-17 15:15 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2021-12-17 13:54:59 PST Comment hidden (obsolete)
Darin Adler
Comment 2 2021-12-17 15:15:19 PST
Created attachment 447483 [details] Patch
Darin Adler
Comment 3 2021-12-17 21:11:59 PST
Looks like all the tests are passing so looking for a review
EWS
Comment 4 2021-12-18 15:58:29 PST
Committed r287232 (245392@main): <https://commits.webkit.org/245392@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447483 [details].
Radar WebKit Bug Importer
Comment 5 2021-12-18 15:59:18 PST
<rdar://problem/86675997>
Simon Fraser (smfr)
Comment 6 2021-12-18 17:46:27 PST
Did you just find all these via code inspection, or did you use any tools?
Darin Adler
Comment 7 2021-12-18 17:57:23 PST
This was what I found by just looking around.
Note You need to log in before you can comment on or make changes to this bug.