Bug 234429

Summary: Update RTCRtpScriptTransformer key frame API according latest spec proposal
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hta, jer.noble, kondapallykalyan, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=234522
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2021-12-17 02:00:21 PST
Update RTCRtpScriptTransformer key frame API according latest spec proposal
Attachments
Patch (18.85 KB, patch)
2021-12-17 02:31 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (18.40 KB, patch)
2021-12-17 02:53 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.92 KB, patch)
2021-12-20 03:06 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-12-17 02:31:51 PST
Created attachment 447443 [details] Patch
youenn fablet
Comment 2 2021-12-17 02:53:46 PST
Created attachment 447445 [details] Patch
Eric Carlson
Comment 3 2021-12-17 11:05:26 PST
Comment on attachment 447445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447445&action=review > Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:154 > + fprintf(stderr, "RTCRtpScriptTransformer::generatetKeyFrame promise resolution\n"); You probably don't want to commit this. > Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:170 > + fprintf(stderr, "RTCRtpScriptTransformer::generateKeyFrame2Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.h \n"); Ditto > Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:180 > + fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest\n"); Ditto > Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:188 > + fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest1\n"); Ditto > Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:193 > + fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest2\n"); Ditto
youenn fablet
Comment 4 2021-12-20 03:06:25 PST
Created attachment 447594 [details] Patch for landing
EWS
Comment 5 2021-12-20 04:40:06 PST
Committed r287258 (245414@main): <https://commits.webkit.org/245414@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447594 [details].
Radar WebKit Bug Importer
Comment 6 2021-12-20 04:41:18 PST
<rdar://problem/86719358>
Note You need to log in before you can comment on or make changes to this bug.