| Summary: | Update RTCRtpScriptTransformer key frame API according latest spec proposal | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hta, jer.noble, kondapallykalyan, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=234522 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2021-12-17 02:00:21 PST
Created attachment 447443 [details]
Patch
Created attachment 447445 [details]
Patch
Comment on attachment 447445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447445&action=review > Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:154 > + fprintf(stderr, "RTCRtpScriptTransformer::generatetKeyFrame promise resolution\n"); You probably don't want to commit this. > Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:170 > + fprintf(stderr, "RTCRtpScriptTransformer::generateKeyFrame2Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.h \n"); Ditto > Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:180 > + fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest\n"); Ditto > Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:188 > + fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest1\n"); Ditto > Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:193 > + fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest2\n"); Ditto Created attachment 447594 [details]
Patch for landing
Committed r287258 (245414@main): <https://commits.webkit.org/245414@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447594 [details]. |