| Summary: | Deduplicate code in RenderText::computePreferredLogicalWidths() | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||
| Component: | Layout and Rendering | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Bug Depends on: | 234421 | ||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Myles C. Maxfield
2021-12-16 21:43:08 PST
Created attachment 447427 [details]
Patch
Created attachment 447431 [details] Depends on bug 234421 Created attachment 447432 [details] Depends on bug 234421 Created attachment 447433 [details] Depends on bug 234421 Created attachment 447434 [details]
Patch for EWS
Created attachment 447435 [details]
Patch for EWS
Created attachment 447460 [details]
Patch
Comment on attachment 447460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447460&action=review > Source/WebCore/ChangeLog:31 > + * rendering/RenderTextInlines.h: Added. This function needs to be able to see into WordTrailingSpace, RenderTextInlines is a bit confusing name but I can't think of a better (not easily confused with inline formatting) name either. Comment on attachment 447460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447460&action=review >> Source/WebCore/ChangeLog:31 >> + * rendering/RenderTextInlines.h: Added. This function needs to be able to see into WordTrailingSpace, > > RenderTextInlines is a bit confusing name but I can't think of a better (not easily confused with inline formatting) name either. Heh, yeah, I didn't even think of that. "Inlines" is the pattern we use in the rest of WebKit, though... Committed r287206 (245373@main): <https://commits.webkit.org/245373@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447460 [details]. |