| Summary: | [LFC][IFC] Let computeIsFirstIsLastBoxForInlineContent update the IsFirstForLayoutBox on the display boxes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2021-12-16 21:18:57 PST
Created attachment 447422 [details]
Patch
Comment on attachment 447422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447422&action=review > Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:458 > +struct FirstLastInlineBoxes { > + HashMap<const Box*, size_t> first; > + HashMap<const Box*, size_t> last; > +}; Alternatively a single HashMap with a struct with optional first/last. Might save a hash lookup though maybe it doesn't matter. (In reply to Antti Koivisto from comment #2) > Comment on attachment 447422 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447422&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:458 > > +struct FirstLastInlineBoxes { > > + HashMap<const Box*, size_t> first; > > + HashMap<const Box*, size_t> last; > > +}; > > Alternatively a single HashMap with a struct with optional first/last. Might > save a hash lookup though maybe it doesn't matter. yeah I like that. Created attachment 447457 [details]
Patch
Committed r287197 (245364@main): <https://commits.webkit.org/245364@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447457 [details]. |